photools.com Community

IMatch Bug Reports and Feature Requests => Bug Reports => Solved Bug Reports (for next version) => Topic started by: ubacher on December 21, 2023, 09:34:38 PM

Title: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: ubacher on December 21, 2023, 09:34:38 PM
All the favorite tiles in selected tabs are too high.
If I activate the files history tab or create a new tab and add entries to it then the tiles are the "proper" height.

I can thus overcome this problem by deleting all existing tabs and recreating them - but I do hope I can
save myself the effort.
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: Mario on December 21, 2023, 09:53:15 PM
I don't follow.
Show us a screen shot.

What happens when you use the command to show or hide individual panels?
The only change in the last version is that tiles have a minimum height based on the system icon size and that the panels update their layout when an icon was loaded in the background.
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: ubacher on December 22, 2023, 06:56:23 AM
Will these screenshots explain?
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: Mario on December 22, 2023, 08:44:16 AM
I look at the Photoshop.exe tile on tile on the left as a reference.
It's icon height determines the height of the tile (with a bit of margin at the top and bottom). The other tiles follow this and must have the same height. There is also a "Photoshop use Raw" favorite with a Ps icon. What is the difference between these two?
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: ubacher on December 22, 2023, 12:36:24 PM

The photoshop shortcut was the problem. I removed it and the tile size shrank. But only for the current tab!
(The other photoshop favorite you saw is an app which calls PS)

Further investigation showed that a PLACEHOLDER put without a specified icon caused all tiles to become large!
However just adding an icon to an existing placeholder did not work. It had to be a just created one.
Can someone verify this?

But I tried the photoshop shortcut again and specified an Icon - this did not make the tile shrink.
I tried specifying an icon file - using an icon from one of my apps - this still resulted in a wide tile.

Now since I have the photoshop favorite on the windows toolbar I put the photoshop favorite in a separate
favorites tab which I don't display. So I am OK so far.

Another try: I created an external tool favorite to call PS. This produced a wide tile. I then specified an icon for this favorite and it narrowed the tile size!

Hope this info helps nailing the problem down.
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: thrinn on December 22, 2023, 01:01:55 PM
Quote from: ubacher on December 22, 2023, 12:36:24 PMFurther investigation showed that a PLACEHOLDER put without a specified icon caused all tiles to become large!
However just adding an icon to an existing placeholder did not work. It had to be a just created one.
Can someone verify this?
As a test, I added a new Favorite set and copied two Favorites to it. This results in:

2023-12-22 12_54_41-IM2020 Pictures.imd5.jpg

Now I add a placeholder, and the height increases:
2023-12-22 13_00_47-IM2020 Pictures.imd5.jpg

So, good catch!
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: thrinn on December 22, 2023, 01:43:40 PM
... and if I add one of the default icons to the placeholde, all favorite tiles shrink to normal height.
When I remove the icon, all favorites extend their height again.

I wonder if the changed High DPI handling (#02166) has something to do with it? Maybe throwing some height calculation off?
Title: Re: Height of favorites tiles in existing tabs twice? the height it should be.
Post by: Mario on December 22, 2023, 03:17:51 PM
QuoteI wonder if the changed High DPI handling (#02166) has something to do with it? Maybe throwing some height calculation off?
No. I've fought the crushed favorite tiles reported by some users by making all tiles assuming that they have an icon and that this icon has the standard Windows icon height (which is something between 32 and 64 pixel, depending on the Windows version, DPI  settings, theme I believe and maybe even font scaling).

The general idea was to make all tiles the same height, assuming standard system icon size. This solved the crushed icon troubles but maybe cause issues when users mix applications, user-defined icons and the built-in icons perhaps?

The default favorite icons included in IMatch are 16 pixel icons and hence look a lot smaller than application icons or store icons. I've never updated them for high-DPI screens I think. The set should be available at 32 and 48 and maybe even 64 pixel to match the system icon sizes.

I'll look into improving this next year.